]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
HID: logitech-hidpp: fix error return code
authorJulia Lawall <Julia.Lawall@lip6.fr>
Sun, 5 Apr 2015 12:06:29 +0000 (14:06 +0200)
committerJiri Kosina <jkosina@suse.cz>
Sun, 5 Apr 2015 20:56:30 +0000 (22:56 +0200)
commitb832da56024b33e6c7f06f766c59d90e4f377a9b
tree7536e2f5b457d8626a5d242a82bffe4f31fd0421
parent9188dbaed68a4b23dc96eba165265c08caa7dc2a
HID: logitech-hidpp: fix error return code

Return a negative error code on failure.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-logitech-hidpp.c