]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
ALSA: hda/conexant: Partial revert of a quirk for Lenovo
authorTakashi Iwai <tiwai@suse.de>
Mon, 20 Mar 2023 14:09:54 +0000 (15:09 +0100)
committerTakashi Iwai <tiwai@suse.de>
Tue, 21 Mar 2023 06:09:21 +0000 (07:09 +0100)
commitb871cb971c683f7f212e7ca3c9a6709a75785116
tree31c5eb2d5abf71a03e3f1b688da7df837349f570
parentb7a5822810c4398515300d614d988cf638adecad
ALSA: hda/conexant: Partial revert of a quirk for Lenovo

The recent commit f83bb2592482 ("ALSA: hda/conexant: Add quirk for
LENOVO 20149 Notebook model") introduced a quirk for the device with
17aa:3977, but this caused a regression on another model (Lenovo
Ideadpad U31) with the very same PCI SSID.  And, through skimming over
the net, it seems that this PCI SSID is used for multiple different
models, so it's no good idea to apply the quirk with the SSID.

Although we may take a different ID check (e.g. the codec SSID instead
of the PCI SSID), unfortunately, the original patch author couldn't
identify the hardware details any longer as the machine was returned,
and we can't develop the further proper fix.

In this patch, instead, we partially revert the change so that the
quirk won't be applied as default for addressing the regression.
Meanwhile, the quirk function itself is kept, and it's now made to be
applicable via the explicit model=lenovo-20149 option.

Fixes: f83bb2592482 ("ALSA: hda/conexant: Add quirk for LENOVO 20149 Notebook model")
Reported-by: Jetro Jormalainen <jje-lxkl@jetro.fi>
Link: https://lore.kernel.org/r/20230308215009.4d3e58a6@mopti
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20230320140954.31154-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/patch_conexant.c