]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
drivers/virt/fsl_hypervisor.c: dereferencing error pointers in ioctl
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 14 May 2019 22:47:00 +0000 (15:47 -0700)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 14 Aug 2019 09:18:49 +0000 (11:18 +0200)
commitb8ab5877c3f654841e8b45f79e1903b1fa8b959b
tree803d7bbf6d27bc5d8067a7cac6b55807340548c8
parent35bc64f6122f8f3956c8205de53933d803289db8
drivers/virt/fsl_hypervisor.c: dereferencing error pointers in ioctl

BugLink: https://bugs.launchpad.net/bugs/1838576
commit c8ea3663f7a8e6996d44500ee818c9330ac4fd88 upstream.

strndup_user() returns error pointers on error, and then in the error
handling we pass the error pointers to kfree().  It will cause an Oops.

Link: http://lkml.kernel.org/r/20181218082003.GD32567@kadam
Fixes: 6db7199407ca ("drivers/virt: introduce Freescale hypervisor management driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Cc: Timur Tabi <timur@freescale.com>
Cc: Mihai Caraman <mihai.caraman@freescale.com>
Cc: Kumar Gala <galak@kernel.crashing.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/virt/fsl_hypervisor.c