]> git.proxmox.com Git - ovs.git/commit
datapath-windows: Fix potential deadlock in event subscription
authorSairam Venugopal <vsairam@vmware.com>
Wed, 27 Feb 2019 00:45:10 +0000 (16:45 -0800)
committerAlin Gabriel Serdean <aserdean@ovn.org>
Wed, 13 Mar 2019 11:21:50 +0000 (13:21 +0200)
commitb8b81ddc43ade00c25b4636cbcdf18f7d906b34a
tree16ce9caddb891d652af53db87a5d630873b1a07c
parent4dc3cc021daafa27af2445b516e90673c02f0134
datapath-windows: Fix potential deadlock in event subscription

Move the EventQueue lock acquisition after the dispatchLock to prevent a
potential deadlock in port creation pipeline. There could be a case where
a port event could try to take up the Dispatch Lock before the Event Queue
lock and the subscription queue event could take up the event queue lock
before the dispatch lock.

Found while testing with Driver Verifier enabled.

Signed-off-by: Sairam Venugopal <vsairam@vmware.com>
Acked-by: Alin Gabriel Serdean <aserdean@ovn.org>
Signed-off-by: Alin Gabriel Serdean <aserdean@ovn.org>
datapath-windows/ovsext/Event.c