]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
sysctl: Fix data races in proc_dointvec_minmax().
authorKuniyuki Iwashima <kuniyu@amazon.com>
Wed, 6 Jul 2022 23:39:54 +0000 (16:39 -0700)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 16 Sep 2022 08:52:44 +0000 (10:52 +0200)
commitb8fe1497d5cc1a026f6225bbd59983e7fd33f015
treec22bf5190993d54ffbc7072e8a69df566aa50a3a
parent34974c1c131fa4decb9152ca2ae780ac481d2537
sysctl: Fix data races in proc_dointvec_minmax().

BugLink: https://bugs.launchpad.net/bugs/1988351
[ Upstream commit f613d86d014b6375a4085901de39406598121e35 ]

A sysctl variable is accessed concurrently, and there is always a chance
of data-race.  So, all readers and writers need some basic protection to
avoid load/store-tearing.

This patch changes proc_dointvec_minmax() to use READ_ONCE() and
WRITE_ONCE() internally to fix data-races on the sysctl side.  For now,
proc_dointvec_minmax() itself is tolerant to a data-race, but we still
need to add annotations on the other subsystem's side.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
kernel/sysctl.c