]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
ptp: Fix resource leak in case of error
authorChristophe Jaillet <christophe.jaillet@wanadoo.fr>
Sun, 2 Oct 2016 07:04:16 +0000 (09:04 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 4 Oct 2016 01:54:10 +0000 (21:54 -0400)
commitb9118b7221ebb12156d2b08d4d5647bc6076d6bb
tree705219e736db000213d2a1433af24ccacc4b1de2
parent0fd7d43fbc4aaf358005231a6bed27eb1c2f60c3
ptp: Fix resource leak in case of error

A call to 'ida_simple_remove()' is missing in the error handling path.

This as been spotted with the following coccinelle script which tries to
detect missing 'ida_simple_remove()' call in error handling paths.

///////////////
@@
expression x;
identifier l;
@@

*   x = ida_simple_get(...);
    ...
    if (...) {
    ...
    }
    ...
    if (...) {
       ...
       goto l;
    }
    ...
*   l: ... when != ida_simple_remove(...);

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Richard Cochran <richardcochran@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/ptp/ptp_clock.c