]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
drm/i915: Only report a wakeup if the waiter was truly asleep
authorChris Wilson <chris@chris-wilson.co.uk>
Sat, 9 Dec 2017 12:47:10 +0000 (12:47 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Mon, 11 Dec 2017 17:23:02 +0000 (17:23 +0000)
commitb92326a04071ed5a02bc31c2359da2cdadde743c
tree3b11326102b3c5cd03ea95892cddce74350abe52
parent776bc27fd8ab67a675cb0041d3af361af5d0e290
drm/i915: Only report a wakeup if the waiter was truly asleep

If we attempt to wake up a waiter, who is currently checking the seqno
it will be in the TASK_INTERRUPTIBLE state and ttwu will report success.
However, it is actually awake and functioning -- so delay reporting the
actual wake up until it sleeps. This fixes some spurious claims of
missed_breadcrumbs when running under heavy load; i.e. sufficient load to
preempt away the newly woken waiter before they complete their checks.
However, it does so at the cost of a rare false negative; where the
waiter changes between the check and ttwu -- the only way to fix that
would be to extend the reporting from ttwu where the check could be done
atomically.

v2: Defend against !CONFIG_SMP
v3: Don't filter out calls to wake_up_process
v4: Drop risky microoptimisation to skip wakeups

Testcase: igt/drv_missed_irq # sanity check we do detect missed_breadcrumb()
Testcase: igt/gem_concurrent_blit # for generating false positives
References: https://bugs.freedesktop.org/show_bug.cgi?id=100007
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20171209124710.1606-1-chris@chris-wilson.co.uk
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
drivers/gpu/drm/i915/intel_breadcrumbs.c