]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
drm/amd/display: return status of dmub_srv_get_fw_boot_status
authorTom Rix <trix@redhat.com>
Thu, 20 Apr 2023 13:59:01 +0000 (09:59 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 9 Jun 2023 13:23:23 +0000 (09:23 -0400)
commitb94f1cc93db72078ad2da02adf1818f5e9122cb7
tree92012b8276101ead689a18adca171e7b08408711
parent4e004146c0bab0c05d66dc648593e8b7ec3d8df5
drm/amd/display: return status of dmub_srv_get_fw_boot_status

gcc with W=1 reports
drivers/gpu/drm/amd/amdgpu/../display/dc/dc_dmub_srv.c:
  In function ‘dc_dmub_srv_optimized_init_done’:
drivers/gpu/drm/amd/amdgpu/../display/dc/dc_dmub_srv.c:184:26:
  error: variable ‘dmub’ set but not used [-Werror=unused-but-set-variable]
  184 |         struct dmub_srv *dmub;
      |                          ^~~~

The return status is never set.
It looks like a call to dmub_srv_get_fw_boot_status is missing.

Fixes: 499e4b1c722e ("drm/amd/display: add mechanism to skip DCN init")
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c