]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
bpf: Zero-fill re-used per-cpu map element
authorDavid Verbeiren <david.verbeiren@tessares.net>
Wed, 4 Nov 2020 11:23:32 +0000 (12:23 +0100)
committerStefan Bader <stefan.bader@canonical.com>
Thu, 10 Dec 2020 11:06:28 +0000 (12:06 +0100)
commitb9ace3e140bc7512995a2aa264535b7a174c7a6d
tree02c1a97cfed69fa2c0a6f4580b04da2b2983b0ca
parentf4020871dafbb207ffc77df80b058a028e6012e8
bpf: Zero-fill re-used per-cpu map element

BugLink: https://bugs.launchpad.net/bugs/1905618
[ Upstream commit d3bec0138bfbe58606fc1d6f57a4cdc1a20218db ]

Zero-fill element values for all other cpus than current, just as
when not using prealloc. This is the only way the bpf program can
ensure known initial values for all cpus ('onallcpus' cannot be
set when coming from the bpf program).

The scenario is: bpf program inserts some elements in a per-cpu
map, then deletes some (or userspace does). When later adding
new elements using bpf_map_update_elem(), the bpf program can
only set the value of the new elements for the current cpu.
When prealloc is enabled, previously deleted elements are re-used.
Without the fix, values for other cpus remain whatever they were
when the re-used entry was previously freed.

A selftest is added to validate correct operation in above
scenario as well as in case of LRU per-cpu map element re-use.

Fixes: 6c9059817432 ("bpf: pre-allocate hash map elements")
Signed-off-by: David Verbeiren <david.verbeiren@tessares.net>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Acked-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20201104112332.15191-1-david.verbeiren@tessares.net
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
kernel/bpf/hashtab.c
tools/testing/selftests/bpf/prog_tests/map_init.c [new file with mode: 0644]
tools/testing/selftests/bpf/progs/test_map_init.c [new file with mode: 0644]