]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
ieee802154: Don't leak memory in ieee802154_nl_fill_phy
authorJesper Juhl <jj@chaosbits.net>
Sun, 12 Jun 2011 04:28:16 +0000 (04:28 +0000)
committerDavid S. Miller <davem@conan.davemloft.net>
Mon, 13 Jun 2011 22:03:22 +0000 (18:03 -0400)
commitb9cabe52c27cf834137f3aaa46da23bcf32284e8
treec620f63c1314e08f50033de489ea39ef92538b9c
parent84860c725364372a331589a600ce6a00437a14f8
ieee802154: Don't leak memory in ieee802154_nl_fill_phy

In net/ieee802154/nl-phy.c::ieee802154_nl_fill_phy() I see two small
issues.
1) If the allocation of 'buf' fails we may just as well return -EMSGSIZE
   directly rather than jumping to 'out:' and do a pointless kfree(0).
2) We do not free 'buf' unless we jump to one of the error labels and this
   leaks memory.
This patch should address both.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Acked-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Signed-off-by: David S. Miller <davem@conan.davemloft.net>
net/ieee802154/nl-phy.c