]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
ARM: 9182/1: mmu: fix returns from early_param() and __setup() functions
authorRandy Dunlap <rdunlap@infradead.org>
Wed, 23 Feb 2022 19:46:35 +0000 (20:46 +0100)
committerPaolo Pisati <paolo.pisati@canonical.com>
Wed, 9 Mar 2022 14:17:55 +0000 (15:17 +0100)
commitb9cac12ae815072a4111e47355b5b26e4fdc1ffa
tree2196637133a808da65b93c93ad05a00fd5d829ab
parenta2ca967aa9edaad472205e7c1a75c94d7444c881
ARM: 9182/1: mmu: fix returns from early_param() and __setup() functions

BugLink: https://bugs.launchpad.net/bugs/1964361
commit 7b83299e5b9385943a857d59e15cba270df20d7e upstream.

early_param() handlers should return 0 on success.
__setup() handlers should return 1 on success, i.e., the parameter
has been handled. A return of 0 would cause the "option=value" string
to be added to init's environment strings, polluting it.

../arch/arm/mm/mmu.c: In function 'test_early_cachepolicy':
../arch/arm/mm/mmu.c:215:1: error: no return statement in function returning non-void [-Werror=return-type]
../arch/arm/mm/mmu.c: In function 'test_noalign_setup':
../arch/arm/mm/mmu.c:221:1: error: no return statement in function returning non-void [-Werror=return-type]

Fixes: b849a60e0903 ("ARM: make cr_alignment read-only #ifndef CONFIG_CPU_CP15")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: Igor Zhbanov <i.zhbanov@omprussia.ru>
Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org
Cc: patches@armlinux.org.uk
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
arch/arm/mm/mmu.c