]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
ata: libahci: Correct setting of DEVSLP register
authorSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Wed, 28 Nov 2018 09:19:00 +0000 (10:19 +0100)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Mon, 14 Jan 2019 09:28:55 +0000 (09:28 +0000)
commitb9e4c3508835eec66f8e4122f35cb1517f19cd67
treefa32512a452407cbbb2b17444c2b599779655f28
parent023e1cc7bbad4f600cd90f268a94a873be79dca2
ata: libahci: Correct setting of DEVSLP register

BugLink: https://bugs.launchpad.net/bugs/1781533
We have seen that on some platforms, SATA device never show any DEVSLP
residency. This prevent power gating of SATA IP, which prevent system
to transition to low power mode in systems with SLP_S0 aka modern
standby systems. The PHY logic is off only in DEVSLP not in slumber.
Reference:
https://www.intel.com/content/dam/www/public/us/en/documents/datasheets
/332995-skylake-i-o-platform-datasheet-volume-1.pdf
Section 28.7.6.1

Here driver is trying to do read-modify-write the devslp register. But
not resetting the bits for which this driver will modify values (DITO,
MDAT and DETO). So simply reset those bits before updating to new values.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
(cherry picked from commit 2dbb3ec29a6c069035857a2fc4c24e80e5dfe3cc)
Signed-off-by: AceLan Kao <acelan.kao@canonical.com>
Acked-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Acked-by: Aaron Ma <aaron.ma@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/ata/libahci.c