]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
usb: dwc3: gadget: Properly check last unaligned/zero chain TRB
authorThinh Nguyen <Thinh.Nguyen@synopsys.com>
Fri, 3 Aug 2018 03:17:16 +0000 (20:17 -0700)
committerFelipe Balbi <felipe.balbi@linux.intel.com>
Tue, 6 Nov 2018 06:40:47 +0000 (08:40 +0200)
commitba3a51ac32ebcf8d0a54b37f1af268ad8a31c52f
treea2af4f3dcd32c0d6dbb271a71e76cf3cee91f0df
parent08fd9a82fda86529bb2f2af3c2f7cb657b4d3066
usb: dwc3: gadget: Properly check last unaligned/zero chain TRB

Current check for the last extra TRB for zero and unaligned transfers
does not account for isoc OUT. The last TRB of the Buffer Descriptor for
isoc OUT transfers will be retired with HWO=0. As a result, we won't
return early. The req->remaining will be updated to include the BUFSIZ
count of the extra TRB, and the actual number of transferred bytes
calculation will be wrong.

To fix this, check whether it's a short or zero packet and the last TRB
chain bit to return early.

Fixes: c6267a51639b ("usb: dwc3: gadget: align transfers to wMaxPacketSize")
Cc: <stable@vger.kernel.org>
Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
drivers/usb/dwc3/gadget.c