]> git.proxmox.com Git - mirror_ovs.git/commit
conntrack: Fix 'reverse_nat_packet()' variable datatype.
authorDarrell Ball <dlu998@gmail.com>
Fri, 30 Aug 2019 16:13:19 +0000 (09:13 -0700)
committerBen Pfaff <blp@ovn.org>
Tue, 24 Sep 2019 20:33:41 +0000 (13:33 -0700)
commitba5ca284098fdf92ca851405c8fab2ef1a4fac39
tree24011a31ecd0d03c73e0cb3c1433d36e3ac7e40f
parentd84109f0b60096ce71cd0537b31b69a7f5ea8756
conntrack: Fix 'reverse_nat_packet()' variable datatype.

The datatype 'pad' in the function 'reverse_nat_packet()' was incorrectly
declared as 'char' instead of 'uint8_t'. This can affect reverse natting
of icmpX packets with padding > 127 bytes.  At the same time, add some
comments regarding 'extract_l3_ipvX' usage in this function.  Found by
inspection.

Fixes: edd1bef468c0 ("dpdk: Add more ICMP Related NAT support.")
Signed-off-by: Darrell Ball <dlu998@gmail.com>
Signed-off-by: Ben Pfaff <blp@ovn.org>
lib/conntrack.c