]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
HID: picoLCD: satify some checkpatch warnings
authorBruno Prémont <bonbons@linux-vserver.org>
Mon, 30 Jul 2012 19:38:54 +0000 (21:38 +0200)
committerJiri Kosina <jkosina@suse.cz>
Wed, 15 Aug 2012 08:12:07 +0000 (10:12 +0200)
commitbaacf9c5d2e631e7c940527ad670c8d4b019da81
treecae5f3fa4e7bd5d0e7ed564be65a29eff5848f47
parentb07072e6a27253b5eb7d21049a108449920b4c50
HID: picoLCD: satify some checkpatch warnings

WARNING: static const char * array should probably be static const char * const
+static const char *error_codes[] = {

WARNING: min() should probably be min_t(size_t, 20, s)
+       raw_data[2] = min((size_t)20, s);

Note: the second min_t suggestion cannot be followed because GCC is not
smart enough to track constants through it and make
copy_from_user_overflow() check happy.

WARNING: min() should probably be min_t(u8, 20, raw_data[2])
+       if (copy_from_user(raw_data+3, u, min((u8)20, raw_data[2])))
                return -EFAULT;

Signed-off-by: Bruno Prémont <bonbons@linux-vserver.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-picolcd_debugfs.c