]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
Revert: "f2fs: check last page index in cached bio to decide submission"
authorChao Yu <yuchao0@huawei.com>
Thu, 27 Sep 2018 15:41:16 +0000 (23:41 +0800)
committerJaegeuk Kim <jaegeuk@kernel.org>
Mon, 1 Oct 2018 01:39:54 +0000 (18:39 -0700)
commitbab475c5414e8d1fa182fd17ae966864e9c85741
treede02f7fdd1e1afed101d5740e433e85e8efcc94c
parentd440c52d3151a28358f4c2d52d8583a0aa54ab83
Revert: "f2fs: check last page index in cached bio to decide submission"

There is one case that we can leave bio in f2fs, result in hanging
page writeback waiter.

Thread A Thread B
- f2fs_write_cache_pages
 - f2fs_submit_page_write
 page #0 cached in bio #0 of cold log
 - f2fs_submit_page_write
 page #1 cached in bio #1 of warm log
- f2fs_write_cache_pages
 - f2fs_submit_page_write
 bio is full, submit bio #1 contain page #1
 - f2fs_submit_merged_write_cond(, page #1)
 fail to submit bio #0 due to page #1 is not in any cached bios.

Signed-off-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/checkpoint.c
fs/f2fs/data.c
fs/f2fs/f2fs.h
fs/f2fs/node.c
fs/f2fs/segment.c