]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
tpm_tis: Disable interrupts on ThinkPad T490s
authorJerry Snitselaar <jsnitsel@redhat.com>
Thu, 15 Oct 2020 21:44:30 +0000 (14:44 -0700)
committerStefan Bader <stefan.bader@canonical.com>
Thu, 10 Dec 2020 11:06:26 +0000 (12:06 +0100)
commitbac02a5da322e226c83a190877aac6e20321751d
treee3f239b1bcfd4fd4061cf49fae11383dfd680010
parent3f4dfa6384c0a613dd0073b93d3642d6775fcd9e
tpm_tis: Disable interrupts on ThinkPad T490s

BugLink: https://bugs.launchpad.net/bugs/1905618
[ Upstream commit b154ce11ead925de6a94feb3b0317fafeefa0ebc ]

There is a misconfiguration in the bios of the gpio pin used for the
interrupt in the T490s. When interrupts are enabled in the tpm_tis
driver code this results in an interrupt storm. This was initially
reported when we attempted to enable the interrupt code in the tpm_tis
driver, which previously wasn't setting a flag to enable it. Due to
the reports of the interrupt storm that code was reverted and we went back
to polling instead of using interrupts. Now that we know the T490s problem
is a firmware issue, add code to check if the system is a T490s and
disable interrupts if that is the case. This will allow us to enable
interrupts for everyone else. If the user has a fixed bios they can
force the enabling of interrupts with tpm_tis.interrupts=1 on the
kernel command line.

Cc: Peter Huewe <peterhuewe@gmx.de>
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com>
Reviewed-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/char/tpm/tpm_tis.c