]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
scsi: qedi: Fix TMF session block/unblock use
authorMike Christie <michael.christie@oracle.com>
Tue, 25 May 2021 18:18:17 +0000 (13:18 -0500)
committerStefan Bader <stefan.bader@canonical.com>
Mon, 20 Sep 2021 13:39:50 +0000 (15:39 +0200)
commitbadcffae5f803fad52f7e51822979f7a64ba4872
tree7ed6e64fde239db3d57b19f724b0bc58b8d644c2
parenta2a543bf2debd0a339856c6a736bad9da143fb0f
scsi: qedi: Fix TMF session block/unblock use

BugLink: https://bugs.launchpad.net/bugs/1939738
[ Upstream commit 2819b4ae2873d50fd55292877b0231ec936c3b2e ]

Drivers shouldn't be calling block/unblock session for tmf handling because
the functions can change the session state from under libiscsi.
iscsi_queuecommand's call to iscsi_prep_scsi_cmd_pdu->
iscsi_check_tmf_restrictions will prevent new cmds from being sent to qedi
after we've started handling a TMF. So we don't need to try and block it in
the driver, and we can remove these block calls.

Link: https://lore.kernel.org/r/20210525181821.7617-25-michael.christie@oracle.com
Reviewed-by: Manish Rangankar <mrangankar@marvell.com>
Signed-off-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/scsi/qedi/qedi_fw.c