]> git.proxmox.com Git - mirror_qemu.git/commit
ivshmem: add missing error exit(2)
authorStefan Hajnoczi <stefanha@redhat.com>
Mon, 3 Jun 2013 08:58:31 +0000 (10:58 +0200)
committerMichael Tokarev <mjt@tls.msk.ru>
Wed, 12 Jun 2013 09:17:53 +0000 (13:17 +0400)
commitbaefb8bf8e4a708c601bbab898a6039cd9cd12e3
treecbc9aa4ae7dd0acc1a9dcd88a382fcf8fa642fbe
parentc5633d998a27502ad8cc10c2d46f91b02555ae7a
ivshmem: add missing error exit(2)

If the user fails to specify 'chardev' or 'shm' then we cannot continue.
Exit right away so that we don't invoke shm_open(3) with a NULL pointer.

It would be nice to replace exit(1) with error returns in the PCI device
.init() function, but leave that for another patch since exit(1) is
currently used elsewhere.

Spotted by Coverity.

Cc: Cam Macdonell <cam@cs.ualberta.ca>
Cc: qemu-stable@nongnu.org
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
hw/misc/ivshmem.c