]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
bpf: Remove redundant synchronize_rcu.
authorAlexei Starovoitov <ast@kernel.org>
Tue, 30 Jun 2020 04:33:39 +0000 (21:33 -0700)
committerAlexei Starovoitov <ast@kernel.org>
Wed, 1 Jul 2020 15:07:13 +0000 (08:07 -0700)
commitbba1dc0b55ac462d24ed1228ad49800c238cd6d7
treed83554930260fe70393ea2d74734357577035dce
parent8c18311067d0f0d5f332b9e1f3859eb15e23332d
bpf: Remove redundant synchronize_rcu.

bpf_free_used_maps() or close(map_fd) will trigger map_free callback.
bpf_free_used_maps() is called after bpf prog is no longer executing:
bpf_prog_put->call_rcu->bpf_prog_free->bpf_free_used_maps.
Hence there is no need to call synchronize_rcu() to protect map elements.

Note that hash_of_maps and array_of_maps update/delete inner maps via
sys_bpf() that calls maybe_wait_bpf_programs() and synchronize_rcu().

Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Andrii Nakryiko <andriin@fb.com>
Acked-by: Paul E. McKenney <paulmck@kernel.org>
Link: https://lore.kernel.org/bpf/20200630043343.53195-2-alexei.starovoitov@gmail.com
kernel/bpf/arraymap.c
kernel/bpf/hashtab.c
kernel/bpf/lpm_trie.c
kernel/bpf/queue_stack_maps.c
kernel/bpf/reuseport_array.c
kernel/bpf/ringbuf.c
kernel/bpf/stackmap.c