]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
usb: typec: wcove: Remove dependency on HW FSM
authorHeikki Krogerus <heikki.krogerus@linux.intel.com>
Thu, 24 May 2018 10:49:52 +0000 (13:49 +0300)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 5 Sep 2018 08:30:45 +0000 (10:30 +0200)
commitbbd572d6aa3b15fb62aea5dea851f13ae952b2b1
treed252ae9855d995bc2363b58266557cf15b3a77f4
parent1f57ead15b0c106168ac4445ee0febcced111614
usb: typec: wcove: Remove dependency on HW FSM

BugLink: http://bugs.launchpad.net/bugs/1790188
commit 05826ff135ee083d28c006fbde6e810f17437166 upstream.

The USB Type-C PHY in Intel WhiskeyCove PMIC has build-in
USB Type-C state machine which we were relying on to
configure the CC lines correctly. This patch removes that
dependency and configures the CC line according to commands
from the port manager (tcpm.c) in wcove_set_cc().

This fixes an issue where USB devices attached to the USB
Type-C port do not get enumerated. When acting as
source/host, the HW FSM sometimes fails to configure the PHY
correctly.

Fixes: 3c4fb9f16921 ("usb: typec: wcove: start using tcpm for USB PD support")
Cc: stable@vger.kernel.org
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/usb/typec/typec_wcove.c