]> git.proxmox.com Git - mirror_qemu.git/commit
vl.c deprecate incorrect CPUs topology
authorIgor Mammedov <imammedo@redhat.com>
Thu, 13 Sep 2018 11:06:01 +0000 (13:06 +0200)
committerEduardo Habkost <ehabkost@redhat.com>
Wed, 24 Oct 2018 09:44:59 +0000 (06:44 -0300)
commitbc1fb850a31468ac4976f3895f01a6d981e06d0a
treea3fa1450e86dac4906819b21bb955ed01721dff8
parenta1f3bb1845e23c38c3bb6ca5e90ac184cfaf1a57
vl.c deprecate incorrect CPUs topology

-smp [cpus],sockets/cores/threads[,maxcpus] should describe topology
so that total number of logical CPUs [sockets * cores * threads]
would be equal to [maxcpus], however historically we didn't have
such check in QEMU and it is possible to start VM with an invalid
topology.
Deprecate invalid options combination so we can make sure that
the topology VM started with is always correct in the future.
Users with an invalid sockets/cores/threads/maxcpus values should
fix their CLI to make sure that
   [sockets * cores * threads] == [maxcpus]

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Andrew Jones <drjones@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <1536836762-273036-2-git-send-email-imammedo@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
[ehabkost: squashed unit test fix]
Message-Id: <20181019215345.521d58d7@igors-macbook-pro.local>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
qemu-deprecated.texi
tests/cpu-plug-test.c
vl.c