]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
sched/fair: Fix FTQ noise bench regression
authorVincent Guittot <vincent.guittot@linaro.org>
Fri, 17 Mar 2017 13:47:22 +0000 (14:47 +0100)
committerIngo Molnar <mingo@kernel.org>
Thu, 23 Mar 2017 06:44:51 +0000 (07:44 +0100)
commitbc4278987e3874da62edf585fe8b3bdd9b53f638
treeada2ebab0eba0ea0822342fdfee4bda29f622338
parentd7921a5ddab8d30e06e321f37eec629f23797486
sched/fair: Fix FTQ noise bench regression

A regression of the FTQ noise has been reported by Ying Huang,
on the following hardware:

  8 threads Intel(R) Core(TM)i7-4770 CPU @ 3.40GHz with 8G memory

... which was caused by this commit:

  commit 4e5160766fcc ("sched/fair: Propagate asynchrous detach")

The only part of the patch that can increase the noise is the update
of blocked load of group entity in update_blocked_averages().

We can optimize this call and skip the update of group entity if its load
and utilization are already null and there is no pending propagation of load
in the task group.

This optimization partly restores the noise score. A more agressive
optimization has been tried but has shown worse score.

Reported-by: ying.huang@linux.intel.com
Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: dietmar.eggemann@arm.com
Cc: ying.huang@intel.com
Fixes: 4e5160766fcc ("sched/fair: Propagate asynchrous detach")
Link: http://lkml.kernel.org/r/1489758442-2877-1-git-send-email-vincent.guittot@linaro.org
[ Fixed typos, improved layout. ]
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/sched/fair.c