]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
drm/i915: Remove stale asserts from i915_gem_find_active_request()
authorChris Wilson <chris@chris-wilson.co.uk>
Tue, 29 May 2018 13:29:18 +0000 (14:29 +0100)
committerJani Nikula <jani.nikula@intel.com>
Thu, 31 May 2018 11:27:03 +0000 (14:27 +0300)
commitbc61ec46e83f84b7f42bd775e18567471f1aaaa6
tree5ed8167c0c8a349f6ae696729fd6e4e60337057a
parent368b554d63948133aca05e63ff8f5f4fbc2804d4
drm/i915: Remove stale asserts from i915_gem_find_active_request()

Since we use i915_gem_find_active_request() from inside
intel_engine_dump() and may call that at any time, we do not guarantee
that the engine is paused nor that the signal kthreads and irq handler
are suspended, so we cannot assert that the breadcrumb doesn't advance
and that the irq hasn't happened on another CPU signaling the request we
believe to be idle.

The second assert removed (that request->engine == engine) remains
valid, but is now more rigorously checked during retirement.

Fixes: f636edb214a5 ("drm/i915: Make i915_engine_info pretty printer to standalone")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180529132922.6831-1-chris@chris-wilson.co.uk
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
(cherry picked from commit cc7cc5343584d90e74b7c929ff2c9a2ec8b49cfe)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/i915_gem.c