]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
nbd: don't allow invalid blocksize settings
authorJens Axboe <axboe@kernel.dk>
Tue, 4 Sep 2018 17:52:34 +0000 (11:52 -0600)
committerJens Axboe <axboe@kernel.dk>
Tue, 4 Sep 2018 17:54:58 +0000 (11:54 -0600)
commitbc811f05d77f47059c197a98b6ad242eb03999cb
treee96cabff009625665432d1b98fba898eabaa89ba
parent3111885015b458c97b4cf272e2a87f1d6f0ed06a
nbd: don't allow invalid blocksize settings

syzbot reports a divide-by-zero off the NBD_SET_BLKSIZE ioctl.
We need proper validation of the input here. Not just if it's
zero, but also if the value is a power-of-2 and in a valid
range. Add that.

Cc: stable@vger.kernel.org
Reported-by: syzbot <syzbot+25dbecbec1e62c6b0dd4@syzkaller.appspotmail.com>
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/nbd.c