]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
USB: don't enable wakeup by default for PCI host controllers
authorAlan Stern <stern@rowland.harvard.edu>
Tue, 13 Jan 2009 16:35:54 +0000 (11:35 -0500)
committerGreg Kroah-Hartman <gregkh@kvm.kroah.org>
Wed, 28 Jan 2009 00:15:32 +0000 (16:15 -0800)
commitbcca06efea883bdf3803a0bb0ffa60f26730387d
tree8dfffd0183fcf38f90aa36c2debee15f8336a96f
parentb90de8aea36ae6fe8050a6e91b031369c4f251b2
USB: don't enable wakeup by default for PCI host controllers

This patch (as1199) changes the initial wakeup settings for PCI USB
host controllers.  The controllers are marked as capable of waking the
system, but wakeup is not enabled by default.

It turns out that enabling wakeup for USB host controllers has a lot
of bad consequences.  As the simplest example, if a USB mouse or
keyboard is unplugged immediately after the computer is put to sleep,
the unplug will cause the system to wake back up again!  We are better
off marking them as wakeup-capable and leaving wakeup disabled.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Reported-by: Rafael J. Wysocki <rjw@sisk.pl>
CC: David Brownell <david-b@pacbell.net>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/core/hcd-pci.c
drivers/usb/host/ehci-pci.c
drivers/usb/host/ohci-hcd.c