]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
drivers/net: Correct NULL test
authorJulia Lawall <julia@diku.dk>
Tue, 9 Feb 2010 06:44:18 +0000 (22:44 -0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 9 Feb 2010 06:44:18 +0000 (22:44 -0800)
commitbcf4d812e66ee95f762b38063d654fd1ff7156b0
tree7b56aa70d64d4f4da6a73cb75974bbc7c05d51e5
parent3af26f58d1920d904da87c3897d23070fe2266b4
drivers/net: Correct NULL test

Test the value that was just allocated rather than the previously tested one.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r@
expression *x;
expression e;
identifier l;
@@

if (x == NULL || ...) {
    ... when forall
    return ...; }
... when != goto l;
    when != x = e
    when != &x
*x == NULL
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ax88796.c