]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
imx-drm: imx-tve: don't call sleeping functions beneath enable_lock spinlock
authorRussell King <rmk+kernel@arm.linux.org.uk>
Mon, 16 Dec 2013 12:38:30 +0000 (12:38 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 18 Dec 2013 01:12:55 +0000 (17:12 -0800)
commitbd5121bbb6b9a89d9d13878fa5bb1e833168ae18
tree83b1b5ffd41f3738408305f6d8326f0433dcdfad
parent4ae078d58ac7fadace7eb30bade8da649ecc4ded
imx-drm: imx-tve: don't call sleeping functions beneath enable_lock spinlock

Enable lock claims that it is serializing tve_enable/disable calls.
However, DRM already serialises mode sets with a mutex, which prevents
encoder/connector functions being called concurrently.  Secondly,
holding a spinlock while calling clk_prepare_enable() is wrong; it
will cause a might_sleep() warning should that debugging be enabled.
So, let's just get rid of the enable_lock.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/imx-drm/imx-tve.c