]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
ixgbe: fix probing of multi-port devices with one MDIO
authorJakub Kicinski <kuba@kernel.org>
Fri, 16 Oct 2020 23:20:06 +0000 (16:20 -0700)
committerJakub Kicinski <kuba@kernel.org>
Sun, 18 Oct 2020 20:01:22 +0000 (13:01 -0700)
commitbd7f14df9492e7d3772812a215fca66e6737e598
treef972d8aac3ce51044f8fbc624384e28a2344768f
parent60f1626f0f866809de801724c3d180a9f322841e
ixgbe: fix probing of multi-port devices with one MDIO

Ian reports that after upgrade from v5.8.14 to v5.9 only one
of his 4 ixgbe netdevs appear in the system.

Quoting the comment on ixgbe_x550em_a_has_mii():
 * Returns true if hw points to lowest numbered PCI B:D.F x550_em_a device in
 * the SoC.  There are up to 4 MACs sharing a single MDIO bus on the x550em_a,
 * but we only want to register one MDIO bus.

This matches the symptoms, since the return value from
ixgbe_mii_bus_init() is no longer ignored we need to handle
the higher ports of x550em without an error.

Fixes: 09ef193fef7e ("net: ethernet: ixgbe: check the return value of ixgbe_mii_bus_init()")
Reported-by: Ian Kumlien <ian.kumlien@gmail.com>
Tested-by: Ian Kumlien <ian.kumlien@gmail.com>
Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Link: https://lore.kernel.org/r/20201016232006.3352947-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c