]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
arm64: percpu: Initialize ret in the default case
authorNathan Chancellor <natechancellor@gmail.com>
Tue, 25 Sep 2018 19:44:59 +0000 (12:44 -0700)
committerJuerg Haefliger <juergh@canonical.com>
Wed, 24 Jul 2019 02:00:13 +0000 (20:00 -0600)
commitbdbee0c15c02dc3eb71385ddfc93f3fb14f73284
treeb787b8283c42bde2e37ef1c94bca440680f90fac
parentef122e7cd0018adf974bb108c6457df8893110d6
arm64: percpu: Initialize ret in the default case

BugLink: https://bugs.launchpad.net/bugs/1836968
[ Upstream commit b5bb425871186303e6936fa2581521bdd1964a58 ]

Clang warns that if the default case is taken, ret will be
uninitialized.

./arch/arm64/include/asm/percpu.h:196:2: warning: variable 'ret' is used
uninitialized whenever switch default is taken
[-Wsometimes-uninitialized]
        default:
        ^~~~~~~
./arch/arm64/include/asm/percpu.h:200:9: note: uninitialized use occurs
here
        return ret;
               ^~~
./arch/arm64/include/asm/percpu.h:157:19: note: initialize the variable
'ret' to silence this warning
        unsigned long ret, loop;
                         ^
                          = 0

This warning appears several times while building the erofs filesystem.
While it's not strictly wrong, the BUILD_BUG will prevent this from
becoming a true problem. Initialize ret to 0 in the default case right
before the BUILD_BUG to silence all of these warnings.

Reported-by: Prasad Sodagudi <psodagud@codeaurora.org>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Dennis Zhou <dennis@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
arch/arm64/include/asm/percpu.h