]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
KVM: arm/arm64: vgic: Add missing irq_lock to vgic_mmio_read_pending
authorAndre Przywara <andre.przywara@arm.com>
Tue, 6 Mar 2018 09:21:06 +0000 (09:21 +0000)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Mon, 27 Aug 2018 14:40:05 +0000 (16:40 +0200)
commitbe4d20a97dc1d77e9923404ecc33d86b8b2be982
tree73fb3db365d8c156a34464478862e581f6f4402b
parent9dc55dd5f5b57008d54e5b2f49fd3ffdda5c0e17
KVM: arm/arm64: vgic: Add missing irq_lock to vgic_mmio_read_pending

BugLink: http://bugs.launchpad.net/bugs/1786352
[ Upstream commit 62b06f8f429cd233e4e2e7bbd21081ad60c9018f ]

Our irq_is_pending() helper function accesses multiple members of the
vgic_irq struct, so we need to hold the lock when calling it.
Add that requirement as a comment to the definition and take the lock
around the call in vgic_mmio_read_pending(), where we were missing it
before.

Fixes: 96b298000db4 ("KVM: arm/arm64: vgic-new: Add PENDING registers handlers")
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
virt/kvm/arm/vgic/vgic-mmio.c
virt/kvm/arm/vgic/vgic.h