]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
drm/i915/gen9: only add the planes actually affected by ddb changes
authorPaulo Zanoni <paulo.r.zanoni@intel.com>
Thu, 29 Sep 2016 19:36:48 +0000 (16:36 -0300)
committerJani Nikula <jani.nikula@intel.com>
Mon, 10 Oct 2016 13:06:40 +0000 (16:06 +0300)
commitbe5c571b2ff3a164d2e14ccc100cb5b2b3d3fb7c
tree082fc1b69f8ca05c93a1e32f450d077319fe5862
parenta3fd4c67af3d8a81d241b3d51b3525f36f1d68bb
drm/i915/gen9: only add the planes actually affected by ddb changes

We were previously adding all the planes owned by the CRTC even when
the ddb partitioning didn't change for them. As a consequence, a lot
of functions were being called when we were just moving the cursor
around the screen, such as skylake_update_primary_plane().

This was causing flickering on the primary plane when moving the
cursor. I'm not 100% sure which operation caused the flickering, but
we were writing to a lot of registers, so it could be any of these
writes. With this patch, just moving the mouse won't add the primary
plane to the commit since it won't trigger a change in DDB
partitioning.

v2: Use skl_ddb_entry_equal() (Lyude).
v3: Change Reported-and-bisected-by: to Reported-by: for checkpatch

Fixes: 05a76d3d6ad1 ("drm/i915/skl: Ensure pipes with changed wms get added to the state")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97888
Cc: Mike Lothian <mike@fireburn.co.uk>
Cc: stable@vger.kernel.org
Reported-by: Mike Lothian <mike@fireburn.co.uk>
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: Lyude <cpaul@redhat.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1475177808-29955-1-git-send-email-paulo.r.zanoni@intel.com
(cherry picked from commit 7f60e200e254cd53ad1bd74a56bdd23e813ac4b7)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/intel_pm.c