]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
clocksource/drivers/mips-gic-timer: Use correct shift count to extract data
authorFelix Fietkau <nbd@nbd.name>
Wed, 28 Feb 2018 09:56:10 +0000 (10:56 +0100)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Mon, 27 Aug 2018 14:40:05 +0000 (16:40 +0200)
commitbe5d4a204feae295489619091a3a6b75e2925fcd
treeae855b03ef68692340810532114c1e67b93782c1
parent93c104897e1dd1aa8fde9859a19969b2c18d3cb4
clocksource/drivers/mips-gic-timer: Use correct shift count to extract data

BugLink: http://bugs.launchpad.net/bugs/1786352
[ Upstream commit 5753405e27f8fe4c42c1537d3ddbd9e058e54cdc ]

__gic_clocksource_init() extracts the GIC_CONFIG_COUNTBITS field from
read_gic_config() by right shifting the register value. The shift count is
determined by the most significant bit (__fls) of the bitmask which is
wrong as it shifts out the complete bitfield.

Use the least significant bit (__ffs) instead to shift the bitfield down to
bit 0.

Fixes: e07127a077c7 ("clocksource: mips-gic-timer: Use new GIC accessor functions")
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: daniel.lezcano@linaro.org
Cc: paul.burton@imgtec.com
Link: https://lkml.kernel.org/r/20180228095610.50341-1-nbd@nbd.name
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/clocksource/mips-gic-timer.c