]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
powerpc/vmlinux.lds: Don't discard .comment
authorMichael Ellerman <mpe@ellerman.id.au>
Thu, 5 Jan 2023 11:42:59 +0000 (22:42 +1100)
committerMichael Ellerman <mpe@ellerman.id.au>
Thu, 5 Jan 2023 13:25:12 +0000 (00:25 +1100)
commitbe5f95c8779e19779dd81927c8574fec5aaba36c
tree2502b32729aed57bd6724c08f7a0295ab521ee68
parent07b050f9290ee012a407a0f64151db902a1520f5
powerpc/vmlinux.lds: Don't discard .comment

Although the powerpc linker script mentions .comment in the DISCARD
section, that has never actually caused it to be discarded, because the
earlier ELF_DETAILS macro (previously STABS_DEBUG) explicitly includes
.comment.

However commit 99cb0d917ffa ("arch: fix broken BuildID for arm64 and
riscv") introduced an earlier use of DISCARD as part of the RO_DATA
macro. With binutils < 2.36 that causes the DISCARD directives later in
the script to be applied earlier, causing .comment to actually be
discarded.

It's confusing to explicitly include and discard .comment, and even more
so if the behaviour depends on the toolchain version. So don't discard
.comment in order to maintain the existing behaviour in all cases.

Fixes: 83a092cf95f2 ("powerpc: Link warning for orphan sections")
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20230105132349.384666-3-mpe@ellerman.id.au
arch/powerpc/kernel/vmlinux.lds.S