]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
tcp: avoid infinite loop in tcp_splice_read()
authorEric Dumazet <edumazet@google.com>
Fri, 3 Feb 2017 22:59:38 +0000 (14:59 -0800)
committerThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Thu, 6 Apr 2017 08:19:24 +0000 (09:19 +0100)
commitbeb8368b2e6381f94f91953fac8072340381091a
tree061a7ffb2e54b0e68c3d6f08aab5d56bc1f66307
parente7223f2d525bfb66725b977c68728d2928a4a650
tcp: avoid infinite loop in tcp_splice_read()

BugLink: http://bugs.launchpad.net/bugs/1666324
[ Upstream commit ccf7abb93af09ad0868ae9033d1ca8108bdaec82 ]

Splicing from TCP socket is vulnerable when a packet with URG flag is
received and stored into receive queue.

__tcp_splice_read() returns 0, and sk_wait_data() immediately
returns since there is the problematic skb in queue.

This is a nice way to burn cpu (aka infinite loop) and trigger
soft lockups.

Again, this gem was found by syzkaller tool.

Fixes: 9c55e01c0cc8 ("[TCP]: Splice receive support.")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Cc: Willy Tarreau <w@1wt.eu>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
net/ipv4/tcp.c