]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
ALSA: hda - Fixes inverted Conexant GPIO mic mute led
authorJeronimo Borque <jeronimo@borque.com.ar>
Mon, 19 Aug 2019 01:35:38 +0000 (22:35 -0300)
committerKhalid Elmously <khalid.elmously@canonical.com>
Thu, 26 Sep 2019 04:34:52 +0000 (00:34 -0400)
commitbef5a2155d3650b2cefa0954bb65a47d61b65132
treec7da263e02d6901f6966044f6c6faf2940884a17
parent8bfbf04a151ceb88586525fd964eb00410b41612
ALSA: hda - Fixes inverted Conexant GPIO mic mute led

BugLink: https://bugs.launchpad.net/bugs/1843338
commit f9ef724d4896763479f3921afd1ee61552fc9836 upstream.

"enabled" parameter historically referred to the device input or
output, not to the led indicator. After the changes added with the led
helper functions the mic mute led logic refers to the led and not to
the mic input which caused led indicator to be negated.
Fixing logic in cxt_update_gpio_led and updated
cxt_fixup_gpio_mute_hook
Also updated debug messages to ease further debugging if necessary.

Fixes: 184e302b46c9 ("ALSA: hda/conexant - Use the mic-mute LED helper")
Suggested-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jeronimo Borque <jeronimo@borque.com.ar>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
sound/pci/hda/patch_conexant.c