]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
pinctrl: samsung: fix missing GPIOLIB on ARM64 Exynos config
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Wed, 20 Apr 2022 14:14:07 +0000 (16:14 +0200)
committerStefan Bader <stefan.bader@canonical.com>
Wed, 22 Jun 2022 12:22:40 +0000 (14:22 +0200)
commitbf0929d23e2efd0b54ee7d1ab4e5e03b715f2f0f
treecacb460ab3dcb3b342afb4a74fe7bc3a39ddd06b
parent3c376d2f8ba67af9cedf5024bb40a72ecfdb8d21
pinctrl: samsung: fix missing GPIOLIB on ARM64 Exynos config

BugLink: https://bugs.launchpad.net/bugs/1978234
commit ac875df4d854ab13d9c4af682a1837a1214fecec upstream.

The Samsung pinctrl drivers depend on OF_GPIO, which is part of GPIOLIB.
ARMv7 Exynos platform selects GPIOLIB and Samsung pinctrl drivers. ARMv8
Exynos selects only the latter leading to possible wrong configuration
on ARMv8 build:

  WARNING: unmet direct dependencies detected for PINCTRL_EXYNOS
    Depends on [n]: PINCTRL [=y] && OF_GPIO [=n] && (ARCH_EXYNOS [=y] || ARCH_S5PV210 || COMPILE_TEST [=y])
    Selected by [y]:
    - ARCH_EXYNOS [=y]

Always select the GPIOLIB from the Samsung pinctrl drivers to fix the
issue.  This requires removing of OF_GPIO dependency (to avoid recursive
dependency), so add dependency on OF for COMPILE_TEST cases.

Reported-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
Fixes: eed6b3eb20b9 ("arm64: Split out platform options to separate Kconfig")
Cc: <stable@vger.kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20220420141407.470955-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
arch/arm/mach-exynos/Kconfig
drivers/pinctrl/samsung/Kconfig