]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
device property: Fix the length used in PROPERTY_ENTRY_STRING()
authorHeikki Krogerus <heikki.krogerus@linux.intel.com>
Wed, 23 Jan 2019 14:44:16 +0000 (17:44 +0300)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 14 Aug 2019 09:18:49 +0000 (11:18 +0200)
commitbf29dc0e1d47f353093258bfb8aeaddc9e5fe37e
tree3523657558bd510ea54f3d42e6452efec3bdf18b
parent5d130ed00a9d2c4cca356b9b5c67f0fc8aa03ad0
device property: Fix the length used in PROPERTY_ENTRY_STRING()

BugLink: https://bugs.launchpad.net/bugs/1837952
commit 2b6e492467c78183bb629bb0a100ea3509b615a5 upstream.

With string type property entries we need to use
sizeof(const char *) instead of the number of characters as
the length of the entry.

If the string was shorter then sizeof(const char *),
attempts to read it would have failed with -EOVERFLOW. The
problem has been hidden because all build-in string
properties have had a string longer then 8 characters until
now.

Fixes: a85f42047533 ("device property: helper macros for property entry creation")
Cc: 4.5+ <stable@vger.kernel.org> # 4.5+
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
include/linux/property.h