]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
[media] Revert "[media] v4l2: vb2: one more fix for REQBUFS()"
authorMarek Szyprowski <m.szyprowski@samsung.com>
Wed, 8 Jun 2011 09:15:05 +0000 (06:15 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Fri, 1 Jul 2011 01:32:28 +0000 (22:32 -0300)
commitbf7b73efb7f52abf56b512546c3bbc35001dd696
treea24f0100160273770911025e7fd458fd02602288
parenta52a82fc3a397261ecbcbd441498be58997379c8
[media] Revert "[media] v4l2: vb2: one more fix for REQBUFS()"

This reverts commit 31901a078af29c33c736dcbf815656920e904632.

Queue should be reinitialized on each REQBUFS() call even if the memory
access method and buffer count have not been changed. The user might have
changed the format and if we go the short path introduced in that commit,
the memory buffer will not be reallocated to fit with new format.

The previous patch was just over-engineered optimization, which just
introduced a bug to videobuf2.

Reported-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
CC: Pawel Osciak <pawel@osciak.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/videobuf2-core.c