]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
net: Fix data-races around weight_p and dev_weight_[rt]x_bias.
authorKuniyuki Iwashima <kuniyu@amazon.com>
Tue, 23 Aug 2022 17:46:45 +0000 (10:46 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 24 Aug 2022 12:46:57 +0000 (13:46 +0100)
commitbf955b5ab8f6f7b0632cdef8e36b14e4f6e77829
tree45d85660cd5cbaa68bdd7e11b9290fdf6d98fc9e
parent1227c1771dd2ad44318aa3ab9e3a293b3f34ff2a
net: Fix data-races around weight_p and dev_weight_[rt]x_bias.

While reading weight_p, it can be changed concurrently.  Thus, we need
to add READ_ONCE() to its reader.

Also, dev_[rt]x_weight can be read/written at the same time.  So, we
need to use READ_ONCE() and WRITE_ONCE() for its access.  Moreover, to
use the same weight_p while changing dev_[rt]x_weight, we add a mutex
in proc_do_dev_weight().

Fixes: 3d48b53fb2ae ("net: dev_weight: TX/RX orthogonality")
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/dev.c
net/core/sysctl_net_core.c
net/sched/sch_generic.c