]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
drm/sun4i: hdmi: Move PAD_CTRL1 setting to mode_set function
authorChen-Yu Tsai <wens@csie.org>
Sat, 14 Oct 2017 04:02:52 +0000 (12:02 +0800)
committerMaxime Ripard <maxime.ripard@free-electrons.com>
Mon, 16 Oct 2017 07:54:46 +0000 (09:54 +0200)
commitbfddd1469740ea27439afa866bff41ef1cd22bb1
tree8344954f4db8782a1685f6606aed1a499d6093cf
parent31f5232effd30808f96772f123300d9d13f0cfd1
drm/sun4i: hdmi: Move PAD_CTRL1 setting to mode_set function

Initially we configured the PAD_CTRL1 register at probe/bind time.
However it seems the HDMI controller will modify some of the bits
in this register by itself. On the A10 it is particularly annoying
as it toggles the output invert bits, which inverts the colors on
the display output.

The U-boot driver this driver is based on sets this register twice,
though it seems it's only needed for actual display output. Hence
we move it to the mode_set function.

Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20171014040252.9621-8-wens@csie.org
drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c