]> git.proxmox.com Git - mirror_qemu.git/commit
nbd: Silence Coverity false positive
authorEric Blake <eblake@redhat.com>
Fri, 6 Nov 2020 20:36:11 +0000 (14:36 -0600)
committerEric Blake <eblake@redhat.com>
Mon, 16 Nov 2020 20:51:12 +0000 (14:51 -0600)
commitc0b21f2e221e5edafb400e8acfa04db3ad5bf956
tree2bd553dc90ecbe23a1b188388b3c39ef1bc11764
parentcb5ed407a1ddadf788fd373fed41c87c9e81e5b0
nbd: Silence Coverity false positive

Coverity noticed (CID 1436125) that we check the return value of
nbd_extent_array_add in most places, but not at the end of
bitmap_to_extents().  The return value exists to break loops before a
future iteration, so there is nothing to check if we are already done
iterating.  Adding a cast to void, plus a comment why, pacifies
Coverity.

Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20201111163510.713855-1-eblake@redhat.com>
[eblake: Prefer cast to void over odd && usage]
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
nbd/server.c