]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
drm/msm: Fix null pointer dereference on pointer edp
authorColin Ian King <colin.king@canonical.com>
Wed, 29 Sep 2021 12:18:57 +0000 (13:18 +0100)
committerStefan Bader <stefan.bader@canonical.com>
Mon, 22 Nov 2021 16:30:58 +0000 (17:30 +0100)
commitc0dd2f2f5e8fce0bbcbb3446ad186dc658d0a791
tree6bade17fd897fe85a075b47a86268a56413b5986
parent4303f83f53b2f7c516b7dbef3c60178120c5517d
drm/msm: Fix null pointer dereference on pointer edp

BugLink: https://bugs.launchpad.net/bugs/1951291
commit 2133c4fc8e1348dcb752f267a143fe2254613b34 upstream.

The initialization of pointer dev dereferences pointer edp before
edp is null checked, so there is a potential null pointer deference
issue. Fix this by only dereferencing edp after edp has been null
checked.

Addresses-Coverity: ("Dereference before null check")
Fixes: ab5b0107ccf3 ("drm/msm: Initial add eDP support in msm drm driver (v5)")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20210929121857.213922-1-colin.king@canonical.com
Signed-off-by: Rob Clark <robdclark@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/gpu/drm/msm/edp/edp_ctrl.c