]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
ALSA: hda: intel: Allow repeatedly probing on codec configuration errors
authorTakashi Iwai <tiwai@suse.de>
Wed, 6 Oct 2021 14:19:40 +0000 (16:19 +0200)
committerTakashi Iwai <tiwai@suse.de>
Thu, 7 Oct 2021 07:15:22 +0000 (09:15 +0200)
commitc0f1886de7e173865f1a0fa7680a1c07954a987f
treed5bee3689fb02bc86bbd3b58ccc4db9f66f10783
parentdd6dd6e3c791db7fdbc5433ec7e450717aa3a0ce
ALSA: hda: intel: Allow repeatedly probing on codec configuration errors

It seems that a few recent AMD systems show the codec configuration
errors at the early boot, while loading the driver at a later stage
works magically.  Although the root cause of the error isn't clear,
it's certainly not bad to allow retrying the codec probe in such a
case if that helps.

This patch adds the capability for retrying the probe upon codec probe
errors on the certain AMD platforms.  The probe_work is changed to a
delayed work, and at the secondary call, it'll jump to the codec
probing.

Note that, not only adding the re-probing, this includes the behavior
changes in the codec configuration function.  Namely,
snd_hda_codec_configure() won't unregister the codec at errors any
longer.  Instead, its caller, azx_codec_configure() unregisters the
codecs with the probe failures *if* any codec has been successfully
configured.  If all codec probe failed, it doesn't unregister but let
it re-probed -- which is the most case we're seeing and this patch
tries to improve.

Even if the driver doesn't re-probe or give up, it will go to the
"free-all" error path, hence the leftover codecs shall be disabled /
deleted in anyway.

BugLink: https://bugzilla.suse.com/show_bug.cgi?id=1190801
Link: https://lore.kernel.org/r/20211006141940.2897-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
include/sound/hda_codec.h
sound/pci/hda/hda_bind.c
sound/pci/hda/hda_codec.c
sound/pci/hda/hda_controller.c
sound/pci/hda/hda_controller.h
sound/pci/hda/hda_intel.c
sound/pci/hda/hda_intel.h