]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
ALSA: usb-audio: fix sign unintended sign extension on left shifts
authorColin Ian King <colin.king@canonical.com>
Thu, 27 Jun 2019 16:43:08 +0000 (17:43 +0100)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 14 Aug 2019 09:18:49 +0000 (11:18 +0200)
commitc19995645fdd651da8a5a179734347edeb8fbc8f
tree58de284bf31d5f6bdd2941832e412426df13495f
parentdd5461155f6f3c69112d08722f25ecbb41e9d6cf
ALSA: usb-audio: fix sign unintended sign extension on left shifts

BugLink: https://bugs.launchpad.net/bugs/1838824
commit 2acf5a3e6e9371e63c9e4ff54d84d08f630467a0 upstream.

There are a couple of left shifts of unsigned 8 bit values that
first get promoted to signed ints and hence get sign extended
on the shift if the top bit of the 8 bit values are set. Fix
this by casting the 8 bit values to unsigned ints to stop the
unintentional sign extension.

Addresses-Coverity: ("Unintended sign extension")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
sound/usb/mixer_quirks.c