]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
kernfs: fix a subdir count leak
authorJianyu Zhan <nasa4836@gmail.com>
Thu, 17 Apr 2014 09:52:10 +0000 (17:52 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 Apr 2014 19:25:13 +0000 (12:25 -0700)
commitc1befb885939cdaaf420c10bbe9ff57aa00446ea
treee46f5797e3b17838b41f874f70facaf7b52bfea5
parenta798c10faf62a505d24e5f6213fbaf904a39623f
kernfs: fix a subdir count leak

Currently kernfs_link_sibling() increates parent->dir.subdirs before
adding the node into parent's chidren rb tree.

Because it is possible that kernfs_link_sibling() couldn't find
a suitable slot and bail out, this leads to a mismatch between
elevated subdir count with actual children node numbers.

This patches fix this problem, by moving the subdir accouting
after the actual addtion happening.

Signed-off-by: Jianyu Zhan <nasa4836@gmail.com>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/kernfs/dir.c