]> git.proxmox.com Git - mirror_qemu.git/commit
hw/char/riscv_htif: Fix printing of console characters on big endian hosts
authorThomas Huth <thuth@redhat.com>
Fri, 21 Jul 2023 09:47:19 +0000 (11:47 +0200)
committerAlistair Francis <alistair.francis@wdc.com>
Mon, 11 Sep 2023 01:45:54 +0000 (11:45 +1000)
commitc255946e3df4d9660e4f468a456633c24393d468
treedc428e7a4df420492db44440c66b116068f61e5d
parent782ee711be9390f3586e615be49585aefd7fcaac
hw/char/riscv_htif: Fix printing of console characters on big endian hosts

The character that should be printed is stored in the 64 bit "payload"
variable. The code currently tries to print it by taking the address
of the variable and passing this pointer to qemu_chr_fe_write(). However,
this only works on little endian hosts where the least significant bits
are stored on the lowest address. To do this in a portable way, we have
to store the value in an uint8_t variable instead.

Fixes: 5033606780 ("RISC-V HTIF Console")
Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Bin Meng <bmeng@tinylab.org>
Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20230721094720.902454-2-thuth@redhat.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
hw/char/riscv_htif.c