]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
netlink: move extack setting into validate_nla()
authorJohannes Berg <johannes.berg@intel.com>
Wed, 26 Sep 2018 09:15:32 +0000 (11:15 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 28 Sep 2018 17:24:39 +0000 (10:24 -0700)
commitc29f1845b2b22974411278bad3a2ac0b7815dfb4
tree068b778699737fdf5bc184913423daa334412c1a
parent48fde90a78f8c67e2bec5061f9725fe363519feb
netlink: move extack setting into validate_nla()

This unifies the code between nla_parse() which sets the bad
attribute pointer and an error message, and nla_validate()
which only sets the bad attribute pointer.

It also cleans up the code for NLA_REJECT and paves the way
for nested policy validation, as it will allow us to easily
skip setting the "generic" message without any extra args
like the **error_msg now, just passing the extack through is
now enough.

While at it, remove the unnecessary label in nla_parse().

Suggested-by: David Ahern <dsahern@gmail.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
lib/nlattr.c