]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
mmc: meson-gx: fix irq ack
authorJerome Brunet <jbrunet@baylibre.com>
Thu, 23 May 2019 14:59:50 +0000 (16:59 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Tue, 28 May 2019 08:23:26 +0000 (10:23 +0200)
commitc2c1e63a80d6e9bb9981fc958cd2dac5346212be
tree928ec2821589ec5f219ee83abb549b2bb9ad404a
parent51b72656bb39fdcb8f3174f4007bcc83ad1d275f
mmc: meson-gx: fix irq ack

While cleaning the ISR of the meson-gx and acking only raised irqs,
the ack of the irq was moved at the very last stage of the function.

This was stable during the initial tests but it triggered issues with
hs200, under specific loads (like booting android). Acking the irqs
after calling the mmc_request_done() causes the problem.

Moving the ack back to the original place solves the issue. Since the
irq is edge triggered, it does not hurt to ack irq even earlier, so
let's do it early in the ISR.

Fixes: 9c5fdb07a28d ("mmc: meson-gx: ack only raised irq")
Tested-by: Neil Armstrong <narmstrong@baylibre.com>
Tested-by: Kevin Hilman <khilman@baylibre.com>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
Tested-by: Brad Harper <bjharper@gmail.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/meson-gx-mmc.c