]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
libceph: Fix ceph_tcp_sendpage()'s more boolean usage
authorBenoît Canet <benoit.canet@nodalink.com>
Thu, 25 Jun 2015 17:32:34 +0000 (20:32 +0300)
committerIlya Dryomov <idryomov@gmail.com>
Mon, 29 Jun 2015 17:03:46 +0000 (20:03 +0300)
commitc2cfa19400979dc1a14bba75f83b451b0cd9507a
treebe54f525471187bb09e130bdd9290e87015ba785
parent6ba8edc0bcbdf337293e60123ddac8fc1c895a3c
libceph: Fix ceph_tcp_sendpage()'s more boolean usage

From struct ceph_msg_data_cursor in include/linux/ceph/messenger.h:

bool    last_piece;     /* current is last piece */

In ceph_msg_data_next():

*last_piece = cursor->last_piece;

A call to ceph_msg_data_next() is followed by:

ret = ceph_tcp_sendpage(con->sock, page, page_offset,
                        length, last_piece);

while ceph_tcp_sendpage() is:

static int ceph_tcp_sendpage(struct socket *sock, struct page *page,
                             int offset, size_t size, bool more)

The logic is inverted: correct it.

Signed-off-by: Benoît Canet <benoit.canet@nodalink.com>
Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
net/ceph/messenger.c